-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't build on mac #629
Comments
Possible workarounds:
|
I tried deleting the mzPlot project, but that didn't completely work. It resolved the error originating in mzPlot, but I ended up getting the same error except localized to the Test project instead. Still working through that one. |
Could probably make a different configuration for Mac (right now, there's Release and Debug), that disincludes the WPF-dependent projects. Then you could specify |
I made a different configuration for Mac that didn't reference mzPlot, and it appears that did the trick. I'll make a pull request to for the new special configuration. |
After some experimenting with different configuration I'm still getting the issue. I'll keep researching the issue, but for now, the only thing that I've found to work is purging all references to mzPlot. |
mzplot is used only minimally in MM in metadraw. maybe you could discuss replacing the mzplot functions w/ something else with @nbollis. He's doing lots of metadraw stuff now. then we could eliminate mzplot from mzlib. |
Making mzPlot a separate library makes sense to me, too. I think there will be some changes in the nuspec file, too, e.g. removing OxyPlot. |
is oxyplot connected to mzplot? |
Yes, I believe it's a dependency of only mzPlot, https://github.com/smith-chem-wisc/mzLib/search?q=oxyplot |
maybe we should have a separate nuget "mzGUI" for things that might just be for windows gui that could screw some other type stuff up? |
Since the recent change in the structure of the code base, I can no longer build on MacOS. I am getting a NETSDK1073: The FrameworkReference 'Microsoft.WindowsDesktop.App.WPF' was not recognized (NETSDK1073) (mzPlot).
Obviously, the issue is that the WPF that mzPlot uses isn't compatible with mac, but in the past I haven't had any issue building or running tests from mzLib.
Anybody know of any workarounds on this? I'll also post something if I can figure it out.
The text was updated successfully, but these errors were encountered: