Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Explicit rJava Dependency for Package Developers #34

Open
BenjaminWolfe opened this issue Aug 2, 2020 · 0 comments
Open

Add Explicit rJava Dependency for Package Developers #34

BenjaminWolfe opened this issue Aug 2, 2020 · 0 comments

Comments

@BenjaminWolfe
Copy link

I've always been able to use your package in R scripts by following the README.

However, when I wrote a simple wrapper package for my organization, which made use of your package (and others) and added some company defaults, helpful messaging, etc., I got this error:

Error in .jinit() : could not find function ".jinit"

In a simple script, this is solved by including the right library calls before loading your package. But that's not something you can do with a package, since it has to be more disciplined around the use of namespaces.

I've already submitted a pull request, PR 13, which solves this issue, has been tested for a year and a half, and can be merged right now.

(When I say it's been tested, I mean I've been using my own fork and have observed no side effects.)

I'll quickly list the changes here, for reference:

  • Add rJava to the dependencies list in the DESCRIPTION file.
  • Fully qualify rJava::.jinit() and rJava::.jcall() with double-colon notation in lines 189 and 190, respectively.
  • Optionally, correct the spelling of "dependencies" in the [README](https://github.com/snowflakedb/dplyr-snowflakedb/blob/master/README.md#r-environment-setup).
@BenjaminWolfe BenjaminWolfe changed the title Add rJava Dependency for Package Developers Add Explicit rJava Dependency for Package Developers Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant