Fix: Removing the self-invoking call from KeyPairAuthenticator.SetSpecializedAuthenticatorData method #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cializedAuthenticatorData
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
A new method, SetSecondaryAuthenticationData, was introduced in the previous commitment "SNOW-715504: MFA token cache support (#988)" by Juan Martinez Ramires. This method is probably meant to be called from SetSpecializedAuthenticatorData implementation instead of using a self-invoking call by mistake. I suggest changing the called method name from SetSpecializedAuthenticatorData to SetSecondaryAuthenticationData. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SetSpecializedAuthenticatorData method override, implemented in KeyPairAuthenticator, has a self-invoking call in the second line of the method's body. This results in the connectors hanging up anytime when KeyPairAuthenticator is configured to be used for authentication.
A new method, SetSecondaryAuthenticationData, was introduced in the previous commitment "SNOW-715504: MFA token cache support (#988)" by Juan Martinez Ramires. This method is probably meant to be called from SetSpecializedAuthenticatorData implementation instead of using a self-invoking call by mistake. I suggest changing the called method name from SetSpecializedAuthenticatorData to SetSecondaryAuthenticationData.