-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1733956: fix sql count of modin tests with cte enabled #2491
Conversation
803e1bb
to
9860f7c
Compare
9860f7c
to
473650b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this change also affects daily precommit, can you post a successful run for those as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!!
yes, https://github.com/snowflakedb/snowpark-python/actions/runs/11485902072, though some tests seem failing with an unrelated error: [31mFAILED�[0m tests/integ/modin/io/test_read_csv.py::�[1mtest_read_csv_usecols_nonexistent_negative[usecols1]�[0m - snowflake.connector.errors.ProgrammingError: 000612 (02000): Result not found |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.