Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1491199 Server-side Snowpark: Update package dependencies #2501

Merged
merged 15 commits into from
Oct 28, 2024
Merged

SNOW-1491199 Server-side Snowpark: Update package dependencies #2501

merged 15 commits into from
Oct 28, 2024

Conversation

sfc-gh-oplaton
Copy link
Contributor

@sfc-gh-oplaton sfc-gh-oplaton commented Oct 24, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1491199

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

Add runtime and development dependencies required for server-side Snowpark phase 0.
Require protobuf and tzlocal at runtime.
Add protoc-wheel-0 to the development profile.
Require version 3.12 or newer of the Snowflake connector.
Describe the dependency updates in CHANGELOG.md.

@sfc-gh-oplaton sfc-gh-oplaton force-pushed the oplaton/snow-1491199-3sp-phase0-dependencies branch from 48e9932 to 13cbebf Compare October 24, 2024 16:50
@sfc-gh-oplaton sfc-gh-oplaton removed the request for review from sfc-gh-lspiegelberg October 24, 2024 16:58
sfc-gh-lspiegelberg
sfc-gh-lspiegelberg reviewed Oct 24, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
sfc-gh-lspiegelberg
sfc-gh-lspiegelberg reviewed Oct 24, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
sfc-gh-lspiegelberg
sfc-gh-lspiegelberg approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some comments about removing some dev packages.

@sfc-gh-oplaton
Copy link
Contributor Author

LGTM, left some comments about removing some dev packages.

Thank you, I was wondering about the vcrpy list.

@sfc-gh-oplaton sfc-gh-oplaton changed the title [SNOW-1491199] Server-side Snowpark: Update package dependencies SNOW-1491199 Server-side Snowpark: Update package dependencies Oct 24, 2024
@sfc-gh-oplaton sfc-gh-oplaton marked this pull request as ready for review October 25, 2024 16:59
@sfc-gh-oplaton sfc-gh-oplaton requested review from a team as code owners October 25, 2024 16:59
sfc-gh-azhan
sfc-gh-azhan reviewed Oct 25, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
sfc-gh-azhan
sfc-gh-azhan approved these changes Oct 25, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@sfc-gh-oplaton sfc-gh-oplaton enabled auto-merge (squash) October 25, 2024 22:37
@sfc-gh-oplaton sfc-gh-oplaton enabled auto-merge (squash) October 28, 2024 17:49
@sfc-gh-oplaton sfc-gh-oplaton merged commit 37f2fb0 into main Oct 28, 2024
36 checks passed
@sfc-gh-oplaton sfc-gh-oplaton deleted the oplaton/snow-1491199-3sp-phase0-dependencies branch October 28, 2024 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg sfc-gh-lspiegelberg approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-rdurrani sfc-gh-rdurrani Awaiting requested review from sfc-gh-rdurrani sfc-gh-rdurrani is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-oplaton @sfc-gh-azhan @sfc-gh-lspiegelberg