Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1491199 add ast-encoding test in precommit #2510

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Oct 25, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1491199

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Before moving source code of IR to this repo, this PR add the test job in CI first which will run in merge gate. We will enforce this check before IR Phase 0 is complete.

@sfc-gh-azhan sfc-gh-azhan added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Oct 25, 2024
@sfc-gh-azhan sfc-gh-azhan force-pushed the azhan-test-ast-1491199 branch from 95fd33e to 28458de Compare October 25, 2024 17:00
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review October 25, 2024 17:04
@sfc-gh-azhan sfc-gh-azhan requested review from a team as code owners October 25, 2024 17:04
@sfc-gh-lspiegelberg
Copy link
Contributor

please also add our team as authors to the PR :) Allows in the future folks to ping us.

Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-azhan
Copy link
Collaborator Author

please also add our team as authors to the PR :) Allows in the future folks to ping us.

I already add code ownership. Where do you want to add author?

@sfc-gh-azhan sfc-gh-azhan merged commit 4bb9960 into main Oct 28, 2024
39 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-test-ast-1491199 branch October 28, 2024 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@sfc-gh-lspiegelberg
Copy link
Contributor

please also add our team as authors to the PR :) Allows in the future folks to ping us.

I already add code ownership. Where do you want to add author?

in github you do

co-authored-by: in the commit message.

cf. https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

this should be done.

@sfc-gh-azhan
Copy link
Collaborator Author

please also add our team as authors to the PR :) Allows in the future folks to ping us.

I already add code ownership. Where do you want to add author?

in github you do

co-authored-by: in the commit message.

cf. https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

this should be done.

Oh just saw this, will add in the followup RPs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants