-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1818205: Add support for pd.json_normalize #2657
Conversation
ab66505
to
8b965ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question, but approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, but I left a couple of comments, and have a few questions:
- Since we're defaulting to native pandas, should we provide some warning to the user or something, that the data will be processed serially in memory, and may be slow for large datasets?
- Do we want to consider adding a distributed/threaded approach later on? (e.g. process batches of data records in parallel by loading them into tables (using https://docs.snowflake.com/en/user-guide/tutorials/script-data-load-transform-json), and then joining those tables?)
As mentioned in another thread, the input data in this case is already in-memory. |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1818205
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add support for pd.json_normalize.