-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1694712] Remove _emit_ast and _ast from docs. #2701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lspiegelberg
added
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
labels
Dec 2, 2024
sfc-gh-lspiegelberg
requested review from
sfc-gh-jdu,
sfc-gh-aling and
sfc-gh-aalam
December 2, 2024 22:14
sfc-gh-aling
reviewed
Dec 3, 2024
sfc-gh-aalam
reviewed
Dec 4, 2024
sfc-gh-aalam
reviewed
Dec 4, 2024
sfc-gh-aling
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving, assuming you will address Afroz's comment
sfc-gh-aling
approved these changes
Dec 5, 2024
sfc-gh-aalam
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
NO-PANDAS-CHANGEDOC-UPDATES
This PR does not update Snowpark pandas docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
FixesSNOW-1694712
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
AST introduces in function signatures (private) parameters
_emit_ast
and_ast
. This PR modifies the sphinx-build to not emit these parameters into the docs. To check that the generation is successful, run e.e. from thedocs
folder