Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1877144: Use only small values in dummy input for type inference #2839

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

sfc-gh-nkumar
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1877144

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

Use only small dummy values here to avoid the risk of certain callables
taking a long time to execute (where execution time is a function of the input value).
As a downside this reduces diversity in input data so will reduce the effectiveness
type inference framework in some rare cases.

@sfc-gh-nkumar sfc-gh-nkumar requested a review from a team as a code owner January 9, 2025 19:42
@sfc-gh-nkumar sfc-gh-nkumar added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs and removed snowpark-pandas labels Jan 9, 2025
@sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-nkumar have you validated that this change improves performance?

Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sfc-gh-nkumar
Copy link
Contributor Author

@sfc-gh-nkumar have you validated that this change improves performance?

Yes

@sfc-gh-nkumar sfc-gh-nkumar enabled auto-merge (squash) January 9, 2025 19:48
@sfc-gh-nkumar sfc-gh-nkumar merged commit 051d837 into main Jan 13, 2025
51 of 53 checks passed
@sfc-gh-nkumar sfc-gh-nkumar deleted the nkumar-SNOW-1877144-slowdown branch January 13, 2025 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants