Repeated API calls orchestration results in error response

[joseph-v]

Calling API endpoint immediately after first call results in SQLAlchemy session error response

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:
Error response

What you expected to happen:
We should be able to call API endpoint immediately

[skdwriting]

@kumarashit and @joseph-v can we close this?

[kumarashit]

Issue analysis:
This issue is very limited to Service definition being creation. In the call to create service definition, we are updating table out of session scope. The sessionmaker for DB has autocommit=false. So there need to be explicit commit. There is another call to add service_definition and commit which will eventually commit. So we may land into this issue.
Ideal fix will be to use all update/add in session scope.
As this call is done by installer only as of now and the changes are involved too. So IMO, these changes can be done later.
@skdwriting @joseph-v @wisererik please suggest

[skdwriting]

1. Please mark this as a known issue and also provide the workaround for custom service definition through scripts
2. This needs to be handled later. Moving to backlog.

[skdwriting]

No impact on the current service definition and testing from dashboard