Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asymmetric inputs for get_con_loss inside _loss_binder #184

Open
pagpires opened this issue Oct 9, 2024 · 0 comments
Open

asymmetric inputs for get_con_loss inside _loss_binder #184

pagpires opened this issue Oct 9, 2024 · 0 comments

Comments

@pagpires
Copy link

pagpires commented Oct 9, 2024

First, thanks for creating this tool!

Is it intentionally to input target_id and binder_id asymmetrically for mask_1d and mask_ib below?

if "hotspot" in opt:
target_id = zeros.at[opt["hotspot"]].set(mask[opt["hotspot"]])
i_con_loss = get_con_loss(inputs, outputs, opt["i_con"], mask_1d=target_id, mask_1b=binder_id)
else:
target_id = zeros.at[:tL].set(mask[:tL])
i_con_loss = get_con_loss(inputs, outputs, opt["i_con"], mask_1d=binder_id, mask_1b=target_id)

Inside get_con_loss there are are some logical_and operations, and seems whether it's asymmetric depends on the input. Not sure if it's a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant