Hardcoded labels instead of i18n shortcodes

[fthobe]

Not all relevant text strings have been integrated with i18 properly.

Solidus Version:
N/A

To Reproduce

Current behavior

• "My Account"

Following items need strings in the language master:

• Open main menu and Close Menu or decide to substitute with more generic open and close as present in en string files
• New (there's a new string used in a different context, we could use that one)
• See all results

Expected behavior
Should use correct translation strings such as <%= I18n.t('spree.my_account') %>

Screenshots
N/A

Desktop (please complete the following information):
Not platform related

Smartphone (please complete the following information):
Not platform related

[fthobe]

Moved into issue description

[benjaminwil]

We were discussing this in the Solidus Slack.

I suggested that solidus_starter_frontend should generate a locales file with translation strings for any translations it requires that aren't included in core Solidus gems.

This is much better than hard coding the English strings into the views, as they are now.

[benjaminwil]

Since solidus_starter_frontend is not a gem, these translations should be in the application namespace.

[fthobe]

Since solidus_starter_frontend is not a gem, these translations should be in the application namespace.

Hey, not having massive experience here, if you create one as an example I am willing to add the missing ones and do also German, Italian and Spanish. I have the feeling I will need it down the road.

[benjaminwil]

We should leave this open. There are others.

[fthobe]

@benjaminwil post them and I fix them! 😜

[benjaminwil]

They seem to already be referenced in the initial message here.

[fthobe]

Ok if you find more do not hesitate to comment here, I will fix them gradually where I find them