New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OSSIndex TTL a config flag #123

Open

zendern opened this issue Apr 12, 2020 · 1 comment

Labels

enhancement help wanted question

Contributor

zendern commented Apr 12, 2020

What are you trying to do?
Allow for more configurability
What feature or behavior is this required for?
Allow people to set how long the TTL for the cached values from ossindex is set for.

nancy/ossindex/ossindex.go

Line 165 in a76019e

    
           err := txn.SetWithTTL([]byte(strings.ToLower(coord)), []byte(coordJSON), time.Hour*12)

How could we solve this issue? (Not knowing is okay!)
Make it configurable and use that value....probably want some logging around it as well.
Anything else?
Possible downside if someone decided to set it to a lower value could get rate limited

cc @bhamail / @DarthHater

zendern added enhancement question labels

Member

DarthHater commented Apr 13, 2020

I doubt we want this as a command line flag, and more so a persistent config value. Any opinions there @zendern ?

DarthHater added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment