Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare sketch parameter parsing, generation with sourmash python layer strategies + testing #117

Open
bluegenes opened this issue Oct 9, 2024 · 0 comments

Comments

@bluegenes
Copy link
Collaborator

Now that the buildutils.rs file contains ~standardized utilities for sketch building, it would be useful to look back at the sourmash python layer parameter string parsing + sketching to compare strategies and make sure we're not missing anything. The goal is to standardize on good behavior we can add to sourmash core.

  1. param string parsing:
  1. template sketch building:

I think sketch_factory may have some better handling of protein vs dna defaults, here we only have a single default set of parameters at the rust level (dna,k=31,scaled=1000)

also related: #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant