rcal-969 Updates to add and use skycell coord info in asn header #1583
+93
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
ddavis-stsci
force-pushed
the
rcal-969_dsd
branch
from
9424242 to
759f04c
Compare
ddavis-stsci
force-pushed
the
rcal-969_dsd
branch
from
1981e8a to
8df70f9
Compare
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
- Coverage 77.94% 77.93% -0.01%
==========================================
Files 115 115
Lines 7622 7624 +2
==========================================
+ Hits 5941 5942 +1
- Misses 1681 1682 +1 ☔ View full report in Codecov by Sentry. |
schlafly
approved these changes
Jan 21, 2025
braingram
reviewed
Jan 22, 2025
| # check to see if the skycell coords are in the asn header if | ||
| # so read the string and convert to a dictionary to match the patch table | ||
| try: | ||
| skycell_record = json.loads(input.asn["skycell_wcs_info"]) |
There was a problem hiding this comment.
Is there an example association file with this input that you would share? Looking at this line of code makes me think this is expecting a json encoded object stored as a string inside the asn. Is that correct? If so, what's the reason for json encoding the skycell_wcs_info (instead of just allowing it to be encoded along with the other structured content of the asn)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-969
Closes #1560
This PR adds additional info to the asn header keyword skycell_wcs_info and updates the mosaic pipeline to use
that information to construct the skycell data from the input exposures.
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.associations.rstchanges/<PR#>.scripts.rstchanges/<PR#>.mosaic_pipeline.rstchanges/<PR#>.patch_match.rststeps
changes/<PR#>.dq_init.rstchanges/<PR#>.saturation.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.jump_detection.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.assign_wcs.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.photom.rstchanges/<PR#>.flux.rstchanges/<PR#>.source_detection.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.resample.rstchanges/<PR#>.source_catalog.rst