New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GaussianVehicleFactory input checks into separate function #6

Open

CarlinLiao opened this issue Feb 6, 2021 · 0 comments

Assignees

Member

CarlinLiao commented Feb 6, 2021 •

edited

Loading

https://github.com/spartalab/aimsim/blob/56e9beaeb158b0c045f117e3b44f2c7421879659/aimsim/endpoints/factories/gaussian.py#L48-L72

From #2 (comment)

I'd refactor this validation into its own function, that you could separately update later and stuff given any potential changes in this

What would that function look like? Does it take the entire blob of input arguments? If so, I don't see how that's much better than letting this init do the error checking itself.

CarlinLiao assigned ribsthakkar

CarlinLiao mentioned this issue

Refactor Road input checks into separate function #12

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment