Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color contrast issues #4871

Open
Tracked by #2410
pkra opened this issue Jan 9, 2025 · 2 comments
Open
Tracked by #2410

color contrast issues #4871

pkra opened this issue Jan 9, 2025 · 2 comments
Labels

Comments

@pkra
Copy link

pkra commented Jan 9, 2025

While working on w3c/aria#2410 I found some contrast issues that can also be observed on https://respec.org/docs/.

  • TOC
    • light & dark mode: "Tables of Content" has insufficient contrast (due to var(--tocsidebar-heading-text))
    • dark mode: .toc code {#005a9c} leads to insufficient contrast
  • highlight.js: in dark mode, the color theme causes contrast issues in most code snippets, in particular html.
  • WebIDL: in light mode, "WebIDL" has insufficient contrast (.idlHeader { color: var(--defrow-border,#fff)})

I'll update this issue if I find more.

@sidvishnoi
Copy link
Member

Apart from syntax highlighting (part of ReSpec), we'd need to file above in w3c/tr-design repo, as same colors get used by Bikeshed too (base.css).

I'll try finding some time this weekend to address this. Happy to review PRs though.

@pkra
Copy link
Author

pkra commented Jan 9, 2025

Thanks @sidvishnoi.

Is there a way to configure the highlight.js theme in the respec configuration? It offers some themes with better contrast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants