Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX improvements #58

Open
4 tasks
dorianim opened this issue May 21, 2023 · 6 comments
Open
4 tasks

UI/UX improvements #58

dorianim opened this issue May 21, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dorianim
Copy link
Member

dorianim commented May 21, 2023

  • Unify padding and make it more responsive. It's sometimes way too big for narrow screens
  • Use skeletons instead of spinners
  • Don't replace content with spinner when navigating to another page (e.g. from /athlete to /)
  • Links on the footer don't have enough contrast, according to https://pagespeed.web.dev
@dorianim dorianim added enhancement New feature or request good first issue Good for newcomers labels May 21, 2023
@shachargiladi
Copy link

Hey, I would like to assign the issue to me. Is it possible?

@dorianim
Copy link
Member Author

Which part of the issue do you want to work on? Do you have any expreience with svelte-kit?

@shachargiladi
Copy link

I have experience with vue and react, I would like to take the second and third tasks

@dorianim
Copy link
Member Author

alright, feel free to open a PR :)

@shachargiladi
Copy link

shachargiladi commented May 22, 2023

Where can i get token for the api you're using? or how can i load a development enviorment of this api

@dorianim
Copy link
Member Author

Ahh, yes. Sorry about that, it's not properly implemented yet. For now, you can use the key

eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpZCI6Imd1ZXN0IiwiaXNzIjoib3JnOnNwZWVkY2xpbWJpbmciLCJleHAiOjB9.MAJ6r5bbf_zWzZdHHrjgwEsXJcdjHgs__axGjgR53lE

But you'll have to change the API_URL in src/utils/constants.ts to https://api-dev.speedclimbing.org/v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants