New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider having From<T> for Scalar #1865

Open

robert3005 opened this issue Jan 9, 2025 · 3 comments

Member

robert3005 commented Jan 9, 2025

It will always produce non nullable scalar and is easy to misuse

Contributor

gatesn commented Jan 9, 2025

Did this come out of a bug?

Contributor

gatesn commented Jan 9, 2025

I tend to prefer the Scalar::bool(b, Nullability) type constructors.

Member Author

robert3005 commented Jan 9, 2025

It did come out of #1864 where the naive thing was wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment