Subscriber.lookupTopic doesn't close connections, leading to excessive ESTABLISHED connections #92
Comments
if (con.getResponseCode() != 200) {
logger.debug("ignoring lookup resp:{} nsqlookupd:{} topic:{}", con.getResponseCode(), lookup, topic);
continue;
}
in = new BufferedReader(new InputStreamReader(con.getInputStream()));Even though closing the InputStream typically triggers HttpURLConnection to automatically close the connection, in the case where the response code is non-200 (i.e., a failure response), the InputStream is not read, and thus the connection is not automatically closed. In such scenarios, the connection remains open unless explicitly disconnected. Should we explicitly call con.disconnect() in cases where the response code is not 200, or is there another recommended way to ensure the connection is properly closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I observed a large number of TCP connections in the ESTABLISHED state. It appears that the method may not be properly closing connections after the request is completed, causing connections to remain open and accumulate over time.
Should we explicitly call
con.disconnect()to ensure connections are properly closed after use?The text was updated successfully, but these errors were encountered: