Duplicate(ish) push notifications for subscribed user and territory

[SatsAllDay]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

When stacker to whom you are subscribed posts in a territory to which you’re subscribed, you receive a push notification for each, e.g.:

1. User posted foo
2. user posted foo in bar territory

These are deduped in the notifications page. They should also be deduped in push notifications.

Screenshots

I forgot to take one before clearing the notifications.

Steps To Reproduce

1. Enable push notifications
2. Subscribe to a user
3. subscribe to a territory
4. wait for the user to post in the territory
5. see 2 notifications

Expected behavior

Only 1 push notification should come through

Logs

No response

Device information

iOS PWA

Additional context

No response

[Soxasora]

Relieved that push notifs works to the point it shows two types of notifications! /kidding

I also think that these types of notifications should be deduped following the same /notifications behavior, I think it would mean using getNotifications without tag filtering first to see if FOLLOW/TERRITORY is there and discard the notification.

edit: Hmm, this could still mess with Apple's rules about onPush events (onPush, if called, must return a notification and must follow a timing that we can't know)

edit2: well we could also check if the user you're subscribed to has posted in a territory you're subscribed to and avoid onPush management altogether

edit3: posted in PR

[SatsAllDay]

edit2: well we could also check if the user you're subscribed to has posted in a territory you're subscribed to and avoid onPush management altogether

This is the fix I envisioned. Not de-duping on the client but rather skipping the push altogether. I think it makes sense to send the “user posted in territory” push if both are applicable. It’s more specific.