Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search should replace separators with space rather than just removing #30

Open
ghost opened this issue Nov 8, 2020 · 2 comments
Open
Labels
help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Nov 8, 2020

If a search string contains e.g. ham/bacon this will end up as hambacon, which makes a match unlikely. Separators like comma, dash, slash, should be replaced with space instead.

@AdultSun
Copy link
Contributor

Was just discussing on Discord, the global search page still has issues with some of these characters.

  1. Searching for ham/bacon does not escape the / character and results in a blank and broken webpage. The only workaround is to manually escape it by searching for ham%2Fbacon instead. Most users would not know to do this or would realize why the search bar suddenly disappeared.
  2. Searching with hyphens for a scene title is broken. For example, say I want to find a scene titled Foo-Bar. Searching with the keywords Foo-Bar or Foo Bar would not match the scene title, but somehow searching FooBar instead would work. This workaround is not at all obvious either.
  3. Keyword normalization does not appear to be applied to all fields equally. For example, the performer Effy End has both Sasha X-Ray and Sasha Xray as aliases on StashDB. Searching for Sasha X-Ray or Sasha Xray only returns scenes with that one particular spelling as the scene alias and not the other. If search is going to ignore separators in titles, it should behave consistently across all other fields as well.

@Flashy78
Copy link
Contributor

#711 enables searching scene titles with hyphens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants