Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EIP55 for ENS verification #8707

Closed
rachelhamlin opened this issue Aug 6, 2019 · 1 comment
Closed

Implement EIP55 for ENS verification #8707

rachelhamlin opened this issue Aug 6, 2019 · 1 comment

Comments

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Aug 6, 2019

Problem

I found a bug in ENS registration where it checks for already owned name. I needed ENS name to test the name UI part and tried to get already owned name registered in the app - but it failed to recognize I am the owner of the name even though I did own the name.

Turns out comparision of resolved name to wallet address in app failed because of difference in eip55 checksum. I got it to recognize my name as owned, by adding eip55/address->checksum on top of ethereum/normalized-address during comparision.

Also of note is that [:app-db :multiaccounts :address] stored is not eip55 checksummed address rather than the address resolved by the contract.

Identified by Bitsikka in #8069.

Implementation

Implement EIP55 for ENS address registration/verification. http://eips.ethereum.org/EIPS/eip-55

Acceptance Criteria

Checksummed and non-checksummed addresses can both be verified and used in Status.

@rachelhamlin
Copy link
Contributor Author

Fixed in #8069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants