Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes from a usability discussion with JJ Hermes #8

Open
4 tasks
gully opened this issue Nov 30, 2017 · 3 comments
Open
4 tasks

Notes from a usability discussion with JJ Hermes #8

gully opened this issue Nov 30, 2017 · 3 comments

Comments

@gully
Copy link
Collaborator

gully commented Nov 30, 2017

I'm talking with JJ Hermes about making some usability improvements to this tool:

  • Smarter contour level assignment i.e. Smarter contour level assignment #5 , c.f. Figure 5 of Douglas et al. 2016
  • Fill whole image with contour
  • What default to use for the Survey-- JJ recommends highest spatial resolution ➡️ lowest spatial resolution, but whole-sky survey seems like a good default.
  • MGS editorial note Reminds me of the some custom 2D Cutout Functionality in astropy.
@gully
Copy link
Collaborator Author

gully commented Nov 30, 2017

Note, I'll be working on some of these in my fork. Another goal would be to either make this a standalone tool, or integrate it into an existing tool like PyKE or k2-flix.

@gully
Copy link
Collaborator Author

gully commented Dec 13, 2017

Working on this with @mirca right now. We are making a setup.py file to make this a standalone CLI.

@gully
Copy link
Collaborator Author

gully commented Dec 13, 2017

Woohoo! we got it working as a command line interface (CLI).

You can now do, for example:

k2pix ../ktwo211348409-c05_lpd-targ.fits.gz --survey='DSS'

The default argparse behavior needs to be tweaked, and that's on our radar (see above also), but just having the tool "pip installable" is useful.

pip install k2pix

Huge thanks to Ze for helping me navigate the subtleties of setup.py entrypoints.

$ k2pix --help
usage: k2pix [-h] [-v] [--output FILENAME] [--survey SURVEY]
             [--stretch STRETCH] [--min_percent %] [--max_percent %]
             [--cmap CMAP] [--contour_color CONTOUR_COLOR]
             tpf_filename [tpf_filename ...]

Plots a co-added Target Pixel File (TPF) from NASA's Kepler/K2/TESS with a
survey image overlaid.

positional arguments:
  tpf_filename          path to one or more Target Pixel Files (TPF)

optional arguments:
  -h, --help            show this help message and exit
  -v, --verbose
  --output FILENAME     .gif or .mp4 output filename (default: gif with the
                        same name as the input file)
  --survey SURVEY       survey (available in skyview) to overlay on the K2
                        image.
  --stretch STRETCH     type of contrast stretching: "linear", "sqrt",
                        "power", "log", or "asinh" (default is "log")
  --min_percent %       minimum cut percentile (default: 1.0)
  --max_percent %       maximum cut percentile (default: 95)
  --cmap CMAP           matplotlib color map name (default: gray)
  --contour_color CONTOUR_COLOR
                        matplotlib color name (default: red)

stephtdouglas added a commit that referenced this issue Jan 18, 2018
[WiP] Usability improvements related to discussion with JJ Hermes (Issue #8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant