Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[weather-api-widget] 3-day forecast use night variants icons during the day #459

Open
xfzv opened this issue Oct 30, 2024 · 4 comments · May be fixed by #464
Open

[weather-api-widget] 3-day forecast use night variants icons during the day #459

xfzv opened this issue Oct 30, 2024 · 4 comments · May be fixed by #464

Comments

@xfzv
Copy link

xfzv commented Oct 30, 2024

Original conversation

Opening this issue as requested in Ryuno-Ki@449f2db#commitcomment-148523178


With

icons = "weather-underground-icons",
icons_extension = ".png",
show_daily_forecast = true,

The night variant icons are used for the 3-day forecast during day time (and probably the other way around, unconfirmed for now):

1

Reverting Ryuno-Ki@449f2db solves the issue but then the current condition icon (in the bar and in the preview) is using the wrong variant:

2

xfzv referenced this issue in Ryuno-Ki/awesome-wm-widgets Oct 30, 2024
I only need to add a prefix when it is not day.

Signed-off-by: André Jaenisch <[email protected]>
@Ryuno-Ki
Copy link
Contributor

Will look into it once #458 is merged.

@Ryuno-Ki Ryuno-Ki linked a pull request Jan 13, 2025 that will close this issue
@Ryuno-Ki
Copy link
Contributor

I had a rare moment of spare time + clear weather forecast and went ahead to write a fix in #464.

@xfzv
Copy link
Author

xfzv commented Jan 13, 2025

So If understand correctly, there is no way to use day icons during the day and night icons during the night?

@Ryuno-Ki
Copy link
Contributor

Not easily. What you could do is guessing that the future will behave similar to today and look at the current date.

This would slightly increase the function signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants