-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[weather-api-widget] 3-day forecast use night variants icons during the day #459
Comments
I only need to add a prefix when it is not day. Signed-off-by: André Jaenisch <[email protected]>
Will look into it once #458 is merged. |
I had a rare moment of spare time + clear weather forecast and went ahead to write a fix in #464. |
So If understand correctly, there is no way to use day icons during the day and night icons during the night? |
Not easily. What you could do is guessing that the future will behave similar to today and look at the current date. This would slightly increase the function signature. |
Original conversation
Opening this issue as requested in Ryuno-Ki@449f2db#commitcomment-148523178
With
The night variant icons are used for the 3-day forecast during day time (and probably the other way around, unconfirmed for now):
Reverting Ryuno-Ki@449f2db solves the issue but then the current condition icon (in the bar and in the preview) is using the wrong variant:
The text was updated successfully, but these errors were encountered: