Game.cs and the similarities to Generic Host

[Billaferd]

Hi All,

I have been reading the source code and realized that the Game.cs and GameBase.cs have some similarities to the GenericHost. They both handle Services, Logging, and configurations.

I was wondering, was there a specific reason the GenericHost or even the IHostedService interface wasn't used? Also, I noticed that the DI Container is also custom, is there a reason Microsoft's implementation wasn't used? or at least the IServiceProvider/IServiceCollection interfaces?

I was looking at the code-only approach and thought it wouldn't be too bad to convert it, but figured there must have been a good reason for it.

[VaclavElias]

One of the reasons, if I am correct, Stride (Xenko) was designed before .NET (Core).

I think, there might be some issue or discussion on your subject (I will try to find). At this time, there isn't enough .NET community to change/push/request it and also it might not suit the game engine. I hope, rather someone more Stride experienced will correct me.

[VaclavElias]

Here:

• Enhancing Startup and DI #1445
• First draft of adding IOC container #1841

[Billaferd]

Thank you so much.

I will be going through this. I didn't see these earlier when I was searching.

[VaclavElias]

No worries. We have tons of content here and there, also search on Discord, for example this conversation

[Doprez]

If you have any suggestions you have probably come into the Stride scene at a good time! I am currently looking into revamping the entire start up process of Stride to make it more streamline so please feel free to share ideas in my PR or in our discussion on some of the start up mechanisms #2524 (comment)

[VaclavElias]

Are your start up updates going to work like a regular .NET GenericHost? As asked above, could it use IHostedService? And then one would add only what is needed? e.g. if I would opt out from Audio, then this wouldn't be added?

Or that would be too much breaking changes to start with?

[Doprez]

Thats one of the things I havent even thought of to be honest. My original goal was to just use the Stride GameSettings for everything but the .NET generic hosts could make a ton of sense especially with its built in extensibility.

Definitely worth a conversation that would likely need to be confirmed by someone like @xen2 or @Eideren. It's been confirmed that my changes were already breaking hence the 5.0 plan instead of anything 4.x.

[Doprez]

Ok so, I was doing some thinking last night and I think this may make a crazy amount of sense.

It could look something like:

gameSettings = GameSettings()
game = GameBuilder()
game.AddConfiguration(gameSettings)
game.AddSurface<SDLGameWIndow>(); // maybe then a handle could be passed in to specify the window and we could add multiple for multi window set ups? 
game.AddGameSystem<AudioSystem>() // We can add GamesSystems as needed rather than the current method

I think Ill look into this more today as I love the idea of the structure at least with how Im thinking of it in my brain.