Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring Label Propagation to Pods in Helm Chart #358

Open
nestoras opened this issue Dec 23, 2024 · 2 comments
Open

Ensuring Label Propagation to Pods in Helm Chart #358

nestoras opened this issue Dec 23, 2024 · 2 comments

Comments

@nestoras
Copy link

In the previous version, you updated the Helm chart to support labels, which work correctly for the Models. However, the pods don't have the proper labels applied to them. Is there a way to ensure the labels propagate to the pods as well?

Thanks

@nason
Copy link
Contributor

nason commented Jan 10, 2025

Hi any update or more information on this?

Our helm chart includes tenancy labels and we see them on model resources, but they are not being applied to the model pods, and it seems like the kubeai server is looking for labels on the model pods (not only on the model resources) for its multi-tenancy features.

@nstogner
Copy link
Contributor

First of all, sorry about the delayed response, we had a lapse in Issue support.

@nestoras KubeAI does not propagate Model labels to the Pods that are created to serve that Model. I think it probably makes sense to pass those along.

@nason Can you elaborate on this: it seems like the kubeai server is looking for labels on the model pods? The check for label selectors (tenancy labels - referring to this doc) lives here and checks the Model's labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants