-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File created with mix of single and double quotes #44
Comments
This case is a bit tricky because it's a newly created file so the code printer has no frame of reference to determine the style preferences. I guess we could poke around and find a similar file type, but im not quite sure if there's an existing Implementing #33 may be able to solve this as well. |
I think we should assume single quotes by default since that's what the new template creation will spit out and is typically used in JS. We can try to get fancier later on, but it probably isn't necessary out of the gate |
those defaults aren't set by us, they're set by there may be a way to hack it now, but the better fix will be to implement #33, so we may as well hold off on this particular change until then |
I mean for the moment we could also only set recast to default to double qoutes, if we know that the file had no content before our modification. But as @AdrianGonz97 suggested, i think we should solve the bigger picture in #33 Edit: Maybe the end result will be a combination of both. |
#33 has been implemented. This is still an issue though. Can we change the default recast setting to single quotes to match the default style for newly created projects? It's not perfect as we'll still have issues for users using double quotes, but should affect fewer users overall |
Also see: #67 (comment) |
Can we just use single quotes everywhere?
The Drizzle adder creates the
drizzle.config.ts
below currently:The text was updated successfully, but these errors were encountered: