Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE-0451 has an additional author by mistake #856

Open
Visckmart opened this issue Nov 24, 2024 · 2 comments · Fixed by swiftlang/swift-evolution#2622
Open

SE-0451 has an additional author by mistake #856

Visckmart opened this issue Nov 24, 2024 · 2 comments · Fixed by swiftlang/swift-evolution#2622
Labels
bug Something isn't working

Comments

@Visckmart
Copy link

The SE-0451 proposal has three authors on the list:

Authors: Tony Allevato, SE-0275, Alfredo Delli Bovi

I believe this informations have been extracted from the proposal page, which contains the following:

Author: Tony Allevato; based on SE-0275 by Alfredo Delli Bovi

I believe the extraction algorithm is taking all links from that line, which works correctly most of the time, but not in this case. I'm not sure what the ideal solution is here, if changing the proposal or the algorithm. The approach I took on my app that makes use of the metadata was to skip over the names that look too much like a proposal ID.

@Visckmart Visckmart added the bug Something isn't working label Nov 24, 2024
@Visckmart
Copy link
Author

@dempseyatgithub

@dempseyatgithub
Copy link
Contributor

I've submitted swiftlang/swift-evolution#2622 to update the SE-0451 proposal.

The previous proposal (SE-0275) should be noted in the optional Previous Proposals field, not the Author field.

The author of SE-0275 is already credited as the author of that proposal and should generally not be listed in the SE-0451 author field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants