diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8dde16c6..6a885bfb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,7 @@ jobs: - name: Install Global Dependencies run: | - composer global require --no-progress --no-scripts --no-plugins symfony/flex dev-main + composer global require --no-progress --no-scripts --no-plugins symfony/flex @dev - name: "Composer install" uses: "ramsey/composer-install@v1" diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b368dc7..ddb114e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ # Changelog +## [v1.13.1](https://github.com/symfony/webpack-encore-bundle/releases/tag/v1.13.1) + +*November 28th, 2021* + +### Bug Fix + +- [#153](https://github.com/symfony/webpack-encore-bundle/pull/153) - Skipping null values from rendering - *@sadikoff* + ## [v1.13.0](https://github.com/symfony/webpack-encore-bundle/releases/tag/v1.13.0) *November 19th, 2021* diff --git a/tests/Asset/EntrypointLookupTest.php b/tests/Asset/EntrypointLookupTest.php index 2f2e366f..5d9b3552 100644 --- a/tests/Asset/EntrypointLookupTest.php +++ b/tests/Asset/EntrypointLookupTest.php @@ -155,7 +155,7 @@ public function testExceptionOnBadFilename() public function testExceptionOnMissingEntry() { $this->expectException(\Symfony\WebpackEncoreBundle\Exception\EntrypointNotFoundException::class); - $this->expectExceptionMessageMatches('/^Could not find the entry "fake_entry" in "[a-zA-Z0-9\/]+". Found: my_entry, other_entry\.$/'); + $this->expectExceptionMessageMatches('/^Could not find the entry "fake_entry" in "[a-zA-Z0-9\/_]+". Found: my_entry, other_entry\.$/'); $this->entrypointLookup->getCssFiles('fake_entry'); } diff --git a/tests/IntegrationTest.php b/tests/IntegrationTest.php index 1834a02d..317155b0 100644 --- a/tests/IntegrationTest.php +++ b/tests/IntegrationTest.php @@ -273,6 +273,12 @@ public function provideRenderStimulusController() 'controllerValues' => ['isEnabled' => true], 'expected' => 'data-controller="true-controller" data-true-controller-is-enabled-value="true"', ]; + + yield 'null-attribute-value-does-not-render' => [ + 'dataOrControllerName' => 'null-controller', + 'controllerValues' => ['firstName' => null], + 'expected' => 'data-controller="null-controller"', + ]; } /**