Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppState.removeEventListener is deprecated and causes crash #132

Open
ArthurSouzaC opened this issue Oct 4, 2024 · 1 comment
Open

AppState.removeEventListener is deprecated and causes crash #132

ArthurSouzaC opened this issue Oct 4, 2024 · 1 comment

Comments

@ArthurSouzaC
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-countdown-component/index.js b/node_modules/react-native-countdown-component/index.js
index b546b82..3127250 100644
--- a/node_modules/react-native-countdown-component/index.js
+++ b/node_modules/react-native-countdown-component/index.js
@@ -51,12 +51,12 @@ class CountDown extends React.Component {
   }
 
   componentDidMount() {
-    AppState.addEventListener('change', this._handleAppStateChange);
+    this.subscription = AppState.addEventListener('change', this._handleAppStateChange);
   }
 
   componentWillUnmount() {
     clearInterval(this.timer);
-    AppState.removeEventListener('change', this._handleAppStateChange);
+    this.subscription.remove()
   }
 
   componentDidUpdate(prevProps, prevState) {

This issue body was partially generated by patch-package.

@GankCC
Copy link

GankCC commented Oct 31, 2024

Thanks a lot, @ArthurSouzaC! You just saved my day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants