Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network to wallet #1241

Open
sdbondi opened this issue Jan 13, 2025 · 0 comments
Open

Add network to wallet #1241

sdbondi opened this issue Jan 13, 2025 · 0 comments
Assignees
Milestone

Comments

@sdbondi
Copy link
Member

sdbondi commented Jan 13, 2025

Problem

Currently all transactions are for network '0' and the network is not validated. This means that transactions for e.g. igor are valid on e.g. mainnet

Proposal 1

Validator
Validate that the transaction network byte is correct for the currently configured network. Otherwise reject the transaction.

walletd

The network byte field already exists on transactions. Add configuration and a cli arg --network to the wallet daemon and use the correct network byte.

@sdbondi sdbondi converted this from a draft issue Jan 13, 2025
@sdbondi sdbondi added this to the v0.8.0 milestone Jan 13, 2025
@sdbondi sdbondi moved this from Backlog to In Progress in Tari Digital Assets Network (DAN) backlog Jan 16, 2025
@sdbondi sdbondi moved this from In Progress to Selected for development in Tari Digital Assets Network (DAN) backlog Jan 16, 2025
@ksrichard ksrichard self-assigned this Jan 16, 2025
@ksrichard ksrichard moved this from Selected for development to In Progress in Tari Digital Assets Network (DAN) backlog Jan 17, 2025
@ksrichard ksrichard moved this from In Progress to In Review in Tari Digital Assets Network (DAN) backlog Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants