Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with react 18 #10

Open
md-redwan-hossain opened this issue May 7, 2022 · 9 comments
Open

incompatible with react 18 #10

md-redwan-hossain opened this issue May 7, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@md-redwan-hossain
Copy link

md-redwan-hossain commented May 7, 2022

I tried to install tawk react package but it throws a error saying incompatible with react dom 18. See the atached error log and screenshot.
https://termbin.com/gb1b
react_bug

@jaoaustero
Copy link
Contributor

Hi @redwan-hossain we are aware on the error and I already submit a pull request on the team, this will be on under review and test. Pull request #11

Thank you

@jaoaustero jaoaustero added the bug Something isn't working label May 11, 2022
@jaoaustero jaoaustero self-assigned this May 11, 2022
@jaoaustero
Copy link
Contributor

Hi @redwan-hossain We already now supporting version 18 of react, we have new updates on the plugin
that will resolve the issue

https://www.npmjs.com/package/@tawk.to/tawk-messenger-react

@soheb-mpc91
Copy link

soheb-mpc91 commented May 31, 2022

### I AM USING TYPESCRIPT.

@jaoaustero - I am trying to use tawk in [email protected], Installation is success but i am getting type error when i try to import
with code import TawkMessengerReact from '@tawk.to/tawk-messenger-react';

image

I am also trying to install with npm package npm i --save-dev @types/tawk.to__tawk-messenger-react but getting below error:

image

@jaoaustero
Copy link
Contributor

Hi @soheb-mpc91 currently we don't yet support typescript but this was the next thing we will update

@soheb-mpc91
Copy link

soheb-mpc91 commented Jun 26, 2022

@jaoaustero - Any update on #10 (comment) ?

@jleknes
Copy link

jleknes commented Aug 22, 2022

Have you considered supporting react 17 in the latest version of the plugin? Now you have set a 18.1.0 as the minimum version of react and react-dom in peerDependencies. This throws a warning if you try to use the plugin with react 17. And do you really need the peer dependency to react-scripts?

@jaoaustero
Copy link
Contributor

@jleknes You can still use this plugin in react 17 by using the lower version 1.0.0

@jleknes
Copy link

jleknes commented Aug 24, 2022

@jaoaustero: Yes, but version 1.0.0 has lots of outdated dependencies with critical vulnerabilities.

Is version 2.0.1 really incompatible with react 17 or have you just set the peerDependency too aggressively?

@smith558
Copy link

Hi @soheb-mpc91 currently we don't yet support typescript but this was the next thing we will update

Just discovered this. This is quite unfortunate for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants