From 0034151c6a88ac5cb25cd21da69fc173f0c085e8 Mon Sep 17 00:00:00 2001 From: dpugliese6 Date: Tue, 7 Jan 2025 18:42:12 +0100 Subject: [PATCH] comments: remove useless TODO comments --- src/application/nat-application.cc | 5 ----- src/application/tcp-stub-client-application.cc | 3 +-- .../helper/null-ntn-demo-mac-layer-simulation-helper.cc | 2 -- src/irs/irs-assisted-spectrum-channel.cc | 3 +-- src/irs/serving-configurator/defined-serving-configurator.cc | 3 --- .../serving-configurator/periodic-serving-configurator.cc | 3 --- src/irs/serving-configurator/random-serving-configurator.cc | 3 --- .../parametric-speed/parametric-speed-drone-mobility-model.h | 1 - src/report/wifi-phy-layer.cc | 2 +- 9 files changed, 3 insertions(+), 22 deletions(-) diff --git a/src/application/nat-application.cc b/src/application/nat-application.cc index 85e9689..9b9fada 100644 --- a/src/application/nat-application.cc +++ b/src/application/nat-application.cc @@ -120,8 +120,6 @@ NatApplication::RecvPktFromExtNetDev(Ptr netdev, const Address& sender) { NS_LOG_FUNCTION(this << netdev << pkt << protocol << sender); - // TODO: This is a fake address. How can we easily retrieve the receiver IP Address from the - // packet? auto receiver = Ipv4Address::GetZero(); return RecvPktFromNetDev(netdev, @@ -154,7 +152,6 @@ NatApplication::RecvPktFromNetDev(Ptr netdev, toBeSent->RemoveHeader(ipHdr); ipv4Protocol = ipHdr.GetProtocol(); - // TODO: if (ipv4Protocol == 6 /* TCP */) if (ipv4Protocol == 17 /* UDP */) { toBeSent->RemoveHeader(udpHdr); @@ -166,7 +163,6 @@ NatApplication::RecvPktFromNetDev(Ptr netdev, auto outPort = m_natTable[entry]; if (!outPort) { - // TODO: TCP could break! if (m_curNatPort <= 0 || m_curNatPort >= UINT16_MAX) m_curNatPort = 1; @@ -204,7 +200,6 @@ NatApplication::RecvPktFromNetDev(Ptr netdev, toBeSent->RemoveHeader(ipHdr); ipv4Protocol = ipHdr.GetProtocol(); - // TODO: if (ipv4Protocol == 6 /* TCP */) if (ipv4Protocol == 17 /* UDP */) { toBeSent->RemoveHeader(udpHdr); diff --git a/src/application/tcp-stub-client-application.cc b/src/application/tcp-stub-client-application.cc index a72eca9..552a632 100644 --- a/src/application/tcp-stub-client-application.cc +++ b/src/application/tcp-stub-client-application.cc @@ -60,8 +60,7 @@ TcpStubClientApplication::StartApplication() NS_LOG_FUNCTION(this); TcpClientServerApplication::StartApplication(); - Simulator::ScheduleNow(&TcpStubClientApplication::Connect, - this); // TODO: parametrize Seconds (0.5) + Simulator::ScheduleNow(&TcpStubClientApplication::Connect, this); // Simulator::Schedule (m_txInterval, &TcpStubClientApplication::SendPacket, this); } diff --git a/src/configuration/helper/null-ntn-demo-mac-layer-simulation-helper.cc b/src/configuration/helper/null-ntn-demo-mac-layer-simulation-helper.cc index 617fcb3..94b633a 100644 --- a/src/configuration/helper/null-ntn-demo-mac-layer-simulation-helper.cc +++ b/src/configuration/helper/null-ntn-demo-mac-layer-simulation-helper.cc @@ -345,8 +345,6 @@ NullNtnDemoMacLayerSimulationHelper::ComputeSnr(ComputeSnrParams& params) const else { // fallback to Topocentric - // TODO: need a threshold to understand if we can simplify to - // Topocentric, or it is better to use a projection return mm->GetPosition(PositionType::TOPOCENTRIC); } }; diff --git a/src/irs/irs-assisted-spectrum-channel.cc b/src/irs/irs-assisted-spectrum-channel.cc index 66b2579..3f60593 100644 --- a/src/irs/irs-assisted-spectrum-channel.cc +++ b/src/irs/irs-assisted-spectrum-channel.cc @@ -161,8 +161,7 @@ IrsAssistedSpectrumChannel::StartTx(Ptr txParams) { NS_LOG_LOGIC("converting txPowerSpectrum SpectrumModelUids " << txSpectrumModelUid << " --> " << rxSpectrumModelUid); - auto rxConverterIt = txInfoIt->second.m_spectrumConverterMap.find( - rxSpectrumModelUid); // TODO: const ref? + auto rxConverterIt = txInfoIt->second.m_spectrumConverterMap.find(rxSpectrumModelUid); if (rxConverterIt == txInfoIt->second.m_spectrumConverterMap.end()) { // No converter means TX SpectrumModel is orthogonal to RX SpectrumModel diff --git a/src/irs/serving-configurator/defined-serving-configurator.cc b/src/irs/serving-configurator/defined-serving-configurator.cc index 87df264..8c603c0 100644 --- a/src/irs/serving-configurator/defined-serving-configurator.cc +++ b/src/irs/serving-configurator/defined-serving-configurator.cc @@ -75,9 +75,6 @@ DefinedServingConfigurator::ScheduleUpdates() { if (periodend <= periodstart + nextupdate) { - // TODO: schedule patch and serving configurator destruction? - // Simulator::Schedule (Seconds (periodstart + nextupdate), - // &DefinedServingConfigurator::DoDispose, this); break; // we have reached the end of the period, no need to continue } if (nextupdate > 0) diff --git a/src/irs/serving-configurator/periodic-serving-configurator.cc b/src/irs/serving-configurator/periodic-serving-configurator.cc index cf68fc8..2c21c8b 100644 --- a/src/irs/serving-configurator/periodic-serving-configurator.cc +++ b/src/irs/serving-configurator/periodic-serving-configurator.cc @@ -77,9 +77,6 @@ PeriodicServingConfigurator::ScheduleUpdates() { if (periodend <= periodstart + nextupdate) { - // TODO: schedule patch and serving configurator destruction? - // Simulator::Schedule (Seconds (nextupdate), &PeriodicServingConfigurator::DoDispose, - // this); break; // we have reached the end of the period, no need to continue } if (nextupdate > 0) diff --git a/src/irs/serving-configurator/random-serving-configurator.cc b/src/irs/serving-configurator/random-serving-configurator.cc index dc64d25..d6bfb5e 100644 --- a/src/irs/serving-configurator/random-serving-configurator.cc +++ b/src/irs/serving-configurator/random-serving-configurator.cc @@ -84,9 +84,6 @@ RandomServingConfigurator::ScheduleUpdates() { if (periodend <= periodstart + nextupdate) { - // TODO: schedule patch and serving configurator destruction? - // Simulator::Schedule (Seconds (nextupdate), &PeriodicServingConfigurator::DoDispose, - // this); break; // we have reached the end of the period, no need to continue } if (nextupdate > 0) diff --git a/src/mobility/parametric-speed/parametric-speed-drone-mobility-model.h b/src/mobility/parametric-speed/parametric-speed-drone-mobility-model.h index f5e621a..21126b5 100644 --- a/src/mobility/parametric-speed/parametric-speed-drone-mobility-model.h +++ b/src/mobility/parametric-speed/parametric-speed-drone-mobility-model.h @@ -46,7 +46,6 @@ class ParametricSpeedDroneMobilityModel : public GeocentricMobilityModel ParametricSpeedDroneMobilityModel(); - // TODO: Put into generic Utility object static FlightPlan ProjectedToGeographicCoordinates( const FlightPlan& flightPlan, GeographicPositions::EarthSpheroidType earthType); diff --git a/src/report/wifi-phy-layer.cc b/src/report/wifi-phy-layer.cc index 4fd19f1..e7d7283 100644 --- a/src/report/wifi-phy-layer.cc +++ b/src/report/wifi-phy-layer.cc @@ -157,7 +157,7 @@ WifiPhyLayer::DoInitialize() { NS_LOG_FUNCTION_NOARGS(); - m_address = GetDeviceAddress(); // TODO: it would be usedul to report it in the XML file. + m_address = GetDeviceAddress(); DoInitializeRssiMonitor(); ProtocolLayer::DoInitialize();