Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA: various input issues #302

Open
vburckhardt opened this issue Sep 30, 2024 · 0 comments
Open

DA: various input issues #302

vburckhardt opened this issue Sep 30, 2024 · 0 comments

Comments

@vburckhardt
Copy link
Member

vburckhardt commented Sep 30, 2024

  • prefix should be in the required tab - not in the optional
  • kms related inputs should be on the optional tab - not on the required one
  • service_credential_names description should give at least one example on how to input the field as it is a json map.
  • related inputs should be grouped together
  • cos related description should be more explicit about what the cos instance and bucket is for.
  • any input variable name should be prefixed with the context when this is not immediately obvious - eg: archive_days -> cos_bucket_archive_days
  • do not use acronyms when this is not obvious - eg: event_notifications and not "en"
  • retention_enabled description seems a copy paste from another input description "Set to true to skip the creation of an IAM authorization policy that permits all Event Notifications instances in the resource group to read the encryption key from the KMS instance."
  • en_key_name -> review description, it would like make no sense for most end-users. "The name for the key that will be created for the Event Notifications. Not used if an existing key is specfied. If a prefix input variable is specified, it is added to this name in the -value format.". I supposed this is the key protect key and en is event_notification, and that this input is not used if an existing crn key is passed? All of this needs to be explicit in the description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants