Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DA code for watsonx.ai #21

Merged
merged 14 commits into from
Jan 15, 2025
Merged

feat: DA code for watsonx.ai #21

merged 14 commits into from
Jan 15, 2025

Conversation

maheshwarishikha
Copy link
Member

@maheshwarishikha maheshwarishikha commented Jan 10, 2025

Description

Adds DA for terraform-ibm-watsonx-ai module
Issue: https://github.ibm.com/GoldenEye/issues/issues/11373

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Adds DA for terraform-ibm-watsonx-ai module

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

1 similar comment
@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

Copy link
Member

@imprateeksh imprateeksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided some comments. Please check.

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
tests/resources/kp-instance/version.tf Outdated Show resolved Hide resolved
solutions/standard/variables.tf Show resolved Hide resolved
}

variable "watsonx_ai_studio_plan" {
default = "professional-v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some specific reason to use professional-v1 plan for DA or we can go ahead with free-v1 plan considering the difference in cost by both plans?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For DA, I think we can have professional plan and also, only one instance can exists with free plan in an account. SO it avoids test failures too.

solutions/standard/variables.tf Outdated Show resolved Hide resolved
ibm_catalog.json Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
solutions/standard/main.tf Show resolved Hide resolved
@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

Tests are failing in all other regions except us-south while configuring watsonx.ai project. The error is :

Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: unexpected response code '500': Error while retrieving the delegated Cloud Object Storage instance for this account. Please contact support or try again later.
│ 
│   with module.watsonx_ai.module.configure_project[0].restapi_object.configure_project,
│   on ../../modules/configure_project/main.tf line 1, in resource "restapi_object" "configure_project":
│    1: resource "restapi_object" "configure_project" {
│ 
╵}

Tried in eu-gb, eu-de, and jp-tok regions, all failed with the above error.
Hence, for time being pr tests are running in us-south only.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

Copy link
Member

@imprateeksh imprateeksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments -

  • Can you please create a separate issue and refer in the comment to trace the untested regions later if the plan is to merge those changes later once functional ?

watsonx-ai-da.svg suggestions:

  • There seems to be some extra area at the top of the image and has a downward arrow which can be removed.

  • Image size can also be increased a bit.

  • watsonx services to Object storage connector has some deflection

ibm_catalog.json Outdated Show resolved Hide resolved
@imprateeksh
Copy link
Member

Some minor comments -

* Can you please create a separate issue and refer in the comment to trace the untested regions later if the plan is to merge those changes later once functional ?

Issue already exists, refer Issue-11932

@maheshwarishikha
Copy link
Member Author

Some minor comments -

* Can you please create a separate issue and refer in the comment to trace the untested regions later if the plan is to merge those changes later once functional ?

watsonx-ai-da.svg suggestions:

* There seems to be some extra area at the top of the image and has a downward arrow which can be removed.

* Image size can also be increased a bit.

* `watsonx services` to `Object storage` connector has some deflection
  1. Issue exists and already referred in pr_test.go and solutions/standard/variables.tf
  2. Ref-architecture has been updated.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

Copy link
Member

@imprateeksh imprateeksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@maheshwarishikha maheshwarishikha merged commit 6c0c903 into main Jan 15, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the watsonx-ai-da branch January 15, 2025 11:14
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants