-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DA code for watsonx.ai #21
Conversation
/run pipeline |
/run pipeline |
1 similar comment
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided some comments. Please check.
} | ||
|
||
variable "watsonx_ai_studio_plan" { | ||
default = "professional-v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some specific reason to use professional-v1
plan for DA or we can go ahead with free-v1
plan considering the difference in cost by both plans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For DA, I think we can have professional plan and also, only one instance can exists with free plan in an account. SO it avoids test failures too.
/run pipeline |
Tests are failing in all other regions except
Tried in |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments -
- Can you please create a separate issue and refer in the comment to trace the untested regions later if the plan is to merge those changes later once functional ?
watsonx-ai-da.svg
suggestions:
-
There seems to be some extra area at the top of the image and has a downward arrow which can be removed.
-
Image size can also be increased a bit.
-
watsonx services
toObject storage
connector has some deflection
Issue already exists, refer Issue-11932 |
|
/run pipeline |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Approved.
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Adds DA for terraform-ibm-watsonx-ai module
Issue: https://github.ibm.com/GoldenEye/issues/issues/11373
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Adds DA for terraform-ibm-watsonx-ai module
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers