Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Verify JS_CHECK_RECURSION and JS_CHECK_STACK_SIZE on iOS #90

Open
enricogior opened this issue Dec 22, 2016 · 1 comment
Open

Verify JS_CHECK_RECURSION and JS_CHECK_STACK_SIZE on iOS #90

enricogior opened this issue Dec 22, 2016 · 1 comment
Assignees

Comments

@enricogior
Copy link
Member

enricogior commented Dec 22, 2016

The two macros are used to detect recursions, but they may be buggy on iOS.

https://github.com/thaliproject/jxcore/blob/master/deps/mozjs/src/jsfriendapi.h#L23-L27
https://github.com/thaliproject/jxcore/blob/master/deps/mozjs/src/jsfriendapi.h#L1000

Verify JS_STACK_GROWTH_DIRECTION and nativeStackLimit on iOS.

@enricogior
Copy link
Member Author

enricogior commented Jan 12, 2017

This turned out to be more complex than expected.
The macros seems to be correct but they may be not work when the call stack mixes JS functions with native functions, but that is just a supposition.

@yaronyg yaronyg added the bug label Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants