-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Iconic Location Labels ๐บ๏ธ #840
Comments
This is something we want to add and is on our ToDo list. But anyone can help us to speed up the process ๐ and can be a great contribution to the project! Current progress:
How you can help! ๐คธโโ๏ธWe prepared everything for its function in this PR #830 and we just need labels to be inserted in our maps file https://github.com/the-hideout/tarkov-dev/blob/main/src/data/maps.json by adding labels Lines 266 to 275 in 2d6ac50
Coordinates ( Lines 271 to 274 in 2d6ac50
And the result will be something like this: You can further adjust the position to obtain the appeal you like.
For other supported properties like |
Do we have to do all maps at once or can I make pr for each map? |
We accept all contributions. So you can do one PR per map with multiple labels, or one PR with a couple of iconic locations in all maps, or any mix-and-match combination ๐ Any help is truly appreciated ๐ |
"I've been working on Interchange, and I've finished the outside. I have a question about the 'top' and 'bottom' properties, though. I understand they range from 10000 to -10000, and I can see for customs they have values like 2, 3, -1. How do I know which value corresponds to each layer of the map? Or, to put it differently, what are the layer values for each of Interchange's first, second, or third floor?" |
Hey, I was actually already working on interchange and quite far along. I'm not sure how we should proceed but possibly we could merge our changes together. I put in the discord that I was working on interchange, but it probably would have been ideal for me to comment it here. As far as answering your question goes: at the top where the json for interchange starts there is an object named "layers", it includes the heights, as well as right above that there is a "heightRange" which is indicative of the ground floor. |
Thanks for the help, I'll take a look. I saw you did the inside of interchange, it looks good. I'll finish up the outside, probably later today. |
Nice work guys so far! ๐ If you start working on a map, ping me here so I can mark you in the "Current progress" table ๐ |
Thanks, working on shoreline atm |
@Shebuka going to work on lighthouse next |
Hello, I am facing an issue while working on the second level of The Lab map. I have set the top/bottom property for each label, but still, when I open the map, labels of both the first and second levels are displayed. However, when I select the second level, only second level labels are visible, and when I switch back to the first level, only first level labels are visible. Even though I have set the top/bottom property for specific layers, I am still encountering the problem when I open the map. |
@Harsh12Codes it's a known bug (discovered on Factory #854) and on our todo list to be fixed next ;) |
Should I create a pull request for the remaining map levels' labels or wait until the bug is fixed? |
@Harsh12Codes I would keep doing labels. Better to have the info then not. Worse goes to worse people can turn off the labels entirely |
Describe the Feature Request
It would be very nice for the awesome maps to have labels on iconic locations around the map. It's very difficult sometimes to navigate and coordinate what you are near. Especially on Streets and especially to those who are new to the game.
The text was updated successfully, but these errors were encountered: