Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient warning that routes are potentially merged too, when merging areas #4296

Open
killakalle opened this issue Oct 7, 2024 · 2 comments

Comments

@killakalle
Copy link

killakalle commented Oct 7, 2024

Probably a bit of an edge case, but I wanted to point it out anyhow.

While restructuring an area, I accidentally merged routes that should not have been merged.

image

How did it happen?

When you are merging areas, there is this big red warning box that informs you about the dangers of merging. In addition it always lists all the routes that are going to be moved over. So far so good, but that is actually the happy flow and is expected.

However, when there are two routes in both sectors with the same name, then it will also merge the routes. In my opinion, that is quite uncommon, and should be pointed out to the user separately. However, because there is always the big red warning box, this bit of information is easily missed as you stop reading the contents after a while of restructuring areas.

image

When can this case happen?

Probably rare, because it only affects areas where there are duplicate route names. You probably don't want to merge routes, when there are a lot of unknown route names, e.g. SN1, SN2, SN3, in both sectors.

Expected:

  • Better highlighting of the unusual case when area merging also merges routes.
@scd
Copy link
Member

scd commented Oct 7, 2024

Good bug report, but can you be more specific with what better highlighting means. Have you got specific ideas on how to highlight.

At the moment I cannot see what we would do to improve the situation. If we knew that a route was unknown then we could exclude merging, but then we would get dup names.

@killakalle
Copy link
Author

killakalle commented Oct 14, 2024

Could you add a second box (e.g. with red color and the current

Happy flow warning box (change color to yellow or white)
"Mergin cannot be undone"
...Details as usual...

Second warning box (red - show only if applicable)
⚠️ Important:
The following routes share identical names and will be merged:

  • No name 1, 7a (Area A) → No name 1, 5c (Area B)

Potentially add an additional confirmation checkbox that needs to be clicked.
☑️ Confirm: I understand that these routes will be merged and cannot be undone.

I guess the most important thing is that the additional route merging activity somehow stands out visually from the Happy flow. Maybe adding a colorful emoji also does the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants