Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code coverage #41

Open
ekohl opened this issue Jan 29, 2024 · 0 comments
Open

Implement code coverage #41

ekohl opened this issue Jan 29, 2024 · 0 comments

Comments

@ekohl
Copy link
Member

ekohl commented Jan 29, 2024

I wonder how we could nicely implement that in https://github.com/theforeman/actions/

The following details need to be considered:

  • we run the tests as a matrix (each branch tests something else, test:$plugin, db:seed, etc), so we'd need unique artifact names somehow
  • the path each plugin wants to archive might be different

My current idea is:

  • have an input artifact_path, which gets passed 1:1 to actions/upload-artifact
  • only execute the step if artifact_path is actually defined AND the task is test:$plugin, so it runs only once

That would allow us to have a stable simple artifact name (test_artifacts or $plugin_artifacts) and allow other steps to consume that again.

Originally posted by @evgeni in theforeman/foreman_fog_proxmox#311 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant