New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep action mailer config together #946

Closed

composerinteralia opened this issue Oct 19, 2018 · 1 comment

Contributor

composerinteralia commented Oct 19, 2018

https://github.com/thoughtbot/suspenders/blob/285c002cb1095a0031444840b8ee1c31324264e8/lib/suspenders/actions.rb#L12..L28 adds action_mailer configuration to the end of the file, whereas https://github.com/thoughtbot/suspenders/blob/285c002cb1095a0031444840b8ee1c31324264e8/lib/suspenders/generators/production/email_generator.rb#L21..L30 adds action_mailer configuration below some other action_mailer configuration. It might be nice to keep related configuration grouped together.

composerinteralia mentioned this issue

Fix email generator #938

Merged

thiagoa changed the title ~~Keep related config together~~ Keep action mailer config together

Contributor

stevepolitodesign commented May 17, 2024

Closed by #1162

stevepolitodesign closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment