Release dbplyr 2.4.0

[mgirlich]

Prepare for release:

• git pull
• Check current CRAN check results
• Check if any deprecation processes should be advanced, as described in Gradual deprecation
• Bump required R version in DESCRIPTION to 3.6
• Polish NEWS
• urlchecker::url_check()
• devtools::build_readme()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• revdepcheck::cloud_check()
  • Andromeda: unclear, can't reproduce...
  • BiocFileCache: Explicitly name argument n in collect() Bioconductor/BiocFileCache#50
  • CDMConnector: Compatibility with dev dbplyr darwin-eu/CDMConnector#6
  • DrugUtilisation: CDMConnector issue
  • editbl: Remove custom implementation of rows_*() openanalytics/editbl#1
  • IncidencePrevalence: CDMConnector issue
  • modeldb: Fix bug revealed by dev dbplyr tidymodels/modeldb#38
  • mlr3db: Compatibility with dev dbplyr mlr-org/mlr3db#35
  • PatientProfiles: CDMConnector issue
  • RPresto: Adapt tests to dev dbplyr prestodb/RPresto#255
  • sparklyr: fixed in sparklyr/sparklyr@fd5d23b
  • SCDB: Compatibility with dev dbplyr ssi-dk/SCDB#37
  • SQLDataFrame: Incompatible with dev dbplyr Bioconductor/SQLDataFrame#6
• Update cran-comments.md
• git push
• Draft blog post — dbplyr 2.4.0 tidyverse.org#659
• Slack link to draft blog in #open-source-comms

Submit to CRAN:

• usethis::use_version('minor')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• Add preemptive link to blog post in pkgdown news menu
• usethis::use_github_release()
• usethis::use_dev_version(push = TRUE)
• Finish blog post
• Tweet

[hadley]

Could you make a list of a the current failures with a link to either an issue or PR for each package? I just want to make sure that I have my bases covered if CRAN sees any problems.

Also have you started work on the blog post? That's part of our release process since it often uncovers bugs. Or do you want me to take a first stab at it?

[mgirlich]

@hadley For me the check boxes only meant whether the package was already fixed. They all have an issue/PR already for some time. I also created a PR for a blog post now tidyverse/tidyverse.org#659

[hadley]

Ah got it. Our usual technique is to check the boxes as we create the issues/PRs, since that's all we need for CRAN submission. I'll take a look at the blog post shortly. Thanks for working on this!

[hadley]

When I run the revdeps I also see failuers for mlr3db and modeldb. And has the sparklyr maintainer been informed about the "checking S3 generic/method consistency" issue?

mlr3db has tests failures that look like this:

── Error ('test_as_sqlite_backend.R:8:3'): data ────────────────────────────────
Error in `private$.data$ops`: The `$` method of <tbl_lazy> is for internal use only.
i Use `dplyr::pull()` to get the values in a column.
Backtrace:

And looks like modeldb has the same problem, but in vignettes:

--- re-building ‘kmeans.Rmd’ using rmarkdown

Quitting from lines 55-56 [unnamed-chunk-3] (kmeans.Rmd)
Error: processing vignette 'kmeans.Rmd' failed with diagnostics:
The `$` method of <tbl_lazy> is for internal use only.
ℹ Use `dplyr::pull()` to get the values in a column.

[hadley]

• This was a real bug in a modeldb vignette. Fix at Fix bug revealed by dev dbplyr tidymodels/modeldb#38
• mlr3db issue was fixed in Compatibility with dev dbplyr mlr-org/mlr3db#35
• sparklyr fixed in dev: sparklyr/sparklyr@fd5d23b

So I think we're good to release 😄 I'll finish it off tomorrow.

[hadley]

@mgirlich do you have masstodon/linkedin profiles you want me to link in the social media announcments?

[hadley]

@mgirlich pinging you again in case you missed this in the notification storm 😄

[hadley]

I just mentioned your github profile so I can close this issue 😄