Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip MariaDB tests on old Windows #1382

Closed
mgirlich opened this issue Oct 27, 2023 · 2 comments · Fixed by #1386
Closed

Skip MariaDB tests on old Windows #1382

mgirlich opened this issue Oct 27, 2023 · 2 comments · Fixed by #1386
Milestone
2.6.0

Comments

@mgirlich
Copy link
Collaborator

mgirlich commented Oct 27, 2023 •
edited
Loading

MariaDB doesn't work properly on Windows + old R. Either increase the minimal tested R version or skip tests. See r-dbi/RMariaDB#317 for more background.
@mgirlich
Copy link
Collaborator Author

@hadley What's your opinion on this?

@mgirlich mgirlich added this to the 2.5.0 milestone Oct 27, 2023
@hadley
Copy link
Member

hadley commented Oct 27, 2023

I think it's probably easiest to just bump the version of windows in the toolchain (with a comment explaining why).

@mgirlich mgirlich mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Skip old R versions on Windows tidyverse/dbplyr
2 participants
@hadley @mgirlich