From 84ffd2e4d512c46f3540f99b2437248e6c8f2178 Mon Sep 17 00:00:00 2001 From: edward-burn Date: Sun, 29 Dec 2024 12:26:27 +0000 Subject: [PATCH 1/5] update bit64::as.integer64 use in test --- tests/testthat/test-backend-postgres.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-backend-postgres.R b/tests/testthat/test-backend-postgres.R index b00403d26..c60512f46 100644 --- a/tests/testthat/test-backend-postgres.R +++ b/tests/testthat/test-backend-postgres.R @@ -335,7 +335,7 @@ test_that("casts `y` column for local df", { out <- tibble( id = bit64::as.integer64(1:2), - val = bit64::as.integer64(10L, 20L), + val = bit64::as.integer64(c(10L, 20L)), arr = structure(c("{1,2}", "{1,2,3}"), class = "pq__int4") ) expect_equal( From aac11081f48fb727e1748bcc95e734fe3b22a1cd Mon Sep 17 00:00:00 2001 From: edward-burn Date: Sun, 29 Dec 2024 13:30:25 +0000 Subject: [PATCH 2/5] update snaps --- tests/testthat/_snaps/backend-sqlite.md | 2 +- tests/testthat/_snaps/tbl-sql.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/_snaps/backend-sqlite.md b/tests/testthat/_snaps/backend-sqlite.md index 9c6450a31..0b0d3a20a 100644 --- a/tests/testthat/_snaps/backend-sqlite.md +++ b/tests/testthat/_snaps/backend-sqlite.md @@ -36,5 +36,5 @@ id parent notused detail - 1 2 0 35 SEARCH test USING COVERING INDEX test_x (x>?) + 1 2 0 0 SEARCH test USING COVERING INDEX test_x (x>?) diff --git a/tests/testthat/_snaps/tbl-sql.md b/tests/testthat/_snaps/tbl-sql.md index f207e90ea..a8b07508f 100644 --- a/tests/testthat/_snaps/tbl-sql.md +++ b/tests/testthat/_snaps/tbl-sql.md @@ -3,7 +3,7 @@ Code mf2 Output - # Source: SQL [3 x 2] + # Source: SQL [?? x 2] # Database: sqlite ?.?.? [:memory:] x y From dbcdd7e05fdeb48bcbb844eec42e3d4fc0d741e8 Mon Sep 17 00:00:00 2001 From: edward-burn Date: Sun, 29 Dec 2024 14:22:11 +0000 Subject: [PATCH 3/5] update snap --- tests/testthat/_snaps/backend-sqlite.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/_snaps/backend-sqlite.md b/tests/testthat/_snaps/backend-sqlite.md index 0b0d3a20a..9c6450a31 100644 --- a/tests/testthat/_snaps/backend-sqlite.md +++ b/tests/testthat/_snaps/backend-sqlite.md @@ -36,5 +36,5 @@ id parent notused detail - 1 2 0 0 SEARCH test USING COVERING INDEX test_x (x>?) + 1 2 0 35 SEARCH test USING COVERING INDEX test_x (x>?) From efd88c03811862876a77fdb9e287f86a3ee9ad62 Mon Sep 17 00:00:00 2001 From: edward-burn Date: Sun, 29 Dec 2024 15:02:45 +0000 Subject: [PATCH 4/5] update mysql date test --- tests/testthat/test-backend-mysql.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-backend-mysql.R b/tests/testthat/test-backend-mysql.R index 14426e912..8b0ac86b0 100644 --- a/tests/testthat/test-backend-mysql.R +++ b/tests/testthat/test-backend-mysql.R @@ -25,7 +25,7 @@ test_that("custom date escaping works as expected", { expect_equal(escape(as.Date("2020-01-01"), con = con), sql("'2020-01-01'")) expect_equal(escape(as.Date(NA), con = con), sql("NULL")) - expect_equal(escape(as.POSIXct("2020-01-01", tz = "UTC"), con = con), sql("'2020-01-01 00:00:00'")) + expect_equal(escape(as.POSIXct("2020-01-01", tz = "UTC"), con = con), sql("'2020-01-01'")) expect_equal(escape(as.POSIXct(NA, tz = "UTC"), con = con), sql("NULL")) }) From 43dc42480833dc4c1993cdf917c5c403b489f740 Mon Sep 17 00:00:00 2001 From: edward-burn Date: Sun, 29 Dec 2024 15:17:09 +0000 Subject: [PATCH 5/5] undo --- tests/testthat/test-backend-mysql.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-backend-mysql.R b/tests/testthat/test-backend-mysql.R index 8b0ac86b0..14426e912 100644 --- a/tests/testthat/test-backend-mysql.R +++ b/tests/testthat/test-backend-mysql.R @@ -25,7 +25,7 @@ test_that("custom date escaping works as expected", { expect_equal(escape(as.Date("2020-01-01"), con = con), sql("'2020-01-01'")) expect_equal(escape(as.Date(NA), con = con), sql("NULL")) - expect_equal(escape(as.POSIXct("2020-01-01", tz = "UTC"), con = con), sql("'2020-01-01'")) + expect_equal(escape(as.POSIXct("2020-01-01", tz = "UTC"), con = con), sql("'2020-01-01 00:00:00'")) expect_equal(escape(as.POSIXct(NA, tz = "UTC"), con = con), sql("NULL")) })