Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of finish_reason #3

Open
jcheng5 opened this issue Aug 29, 2024 · 2 comments
Open

Make use of finish_reason #3

jcheng5 opened this issue Aug 29, 2024 · 2 comments

Comments

@jcheng5
Copy link
Collaborator

jcheng5 commented Aug 29, 2024

https://platform.openai.com/docs/guides/function-calling/edge-cases

Especially the finish_reason == "length" case, where things like tool calls might be malformed because the context window was exhausted.
@hadley
Copy link
Member

hadley commented Aug 29, 2024 •
edited
Loading

If we get a finish_reason that represents an error state, do we need to provide some tool to pop off the previous message from the stack so that you can start again?

@hadley
Copy link
Member

hadley commented Nov 26, 2024

At a minimum need to start recording this in the Turn object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @jcheng5