Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "--version" to download-firmware script. #91

Open
mithro opened this issue Jan 20, 2018 · 4 comments
Open

Add a "--version" to download-firmware script. #91

mithro opened this issue Jan 20, 2018 · 4 comments

Comments

@mithro
Copy link
Member

mithro commented Jan 20, 2018

No description provided.

@Nancy-Chauhan
Copy link

@mithro Sir I have analysed that HDMI2USB-mode-switch/bin/download-prebuilt-firmware.py is responsible for downloading the firmware script and further analysed that adding --version to parseargs() can help us to solve this issue ? I want to ask you whether I am thinking in right direction or not ? can you provide me further detail about this issue . I will be thankful to you for this

@CarlFK
Copy link
Contributor

CarlFK commented Mar 19, 2018

Nancy,
yes, please do this.

we should probably use the same 'framework' as the mode-swtich command, which is here:

https://github.com/timvideos/HDMI2USB-mode-switch/blob/master/hdmi2usb/modeswitch/cli.py#L275
https://github.com/timvideos/HDMI2USB-mode-switch/blob/master/hdmi2usb/modeswitch/_version.py

also, maybe we should move download-firmware.py into this dir.

GitHub
HDMI2USB-mode-switch - Tool for switching boards supported by HDMI2USB firmware between multiple different modes (programming, webcam, etc).
GitHub
HDMI2USB-mode-switch - Tool for switching boards supported by HDMI2USB firmware between multiple different modes (programming, webcam, etc).

@Nancy-Chauhan
Copy link

Nancy-Chauhan commented Mar 19, 2018

@CarlFK sir As I analyse the issue we have to just add latest version (which is to be downloaded and make change in parseargs() as I have done in line no. 93 (https://paste.ubuntu.com/p/wvxkbHQPdS/) and make necessary change in make corresponding change in image_url please correct me if I am wrong . so that I can open pull request for it soon.

https://paste.ubuntu.com/p/wvxkbHQPdS/

@CarlFK
Copy link
Contributor

CarlFK commented Mar 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants