-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "--version" to download-firmware script. #91
Comments
@mithro Sir I have analysed that HDMI2USB-mode-switch/bin/download-prebuilt-firmware.py is responsible for downloading the firmware script and further analysed that adding --version to parseargs() can help us to solve this issue ? I want to ask you whether I am thinking in right direction or not ? can you provide me further detail about this issue . I will be thankful to you for this |
Nancy, we should probably use the same 'framework' as the mode-swtich command, which is here: https://github.com/timvideos/HDMI2USB-mode-switch/blob/master/hdmi2usb/modeswitch/cli.py#L275 also, maybe we should move download-firmware.py into this dir.
|
@CarlFK sir As I analyse the issue we have to just add latest version (which is to be downloaded and make change in parseargs() as I have done in line no. 93 (https://paste.ubuntu.com/p/wvxkbHQPdS/) and make necessary change in make corresponding change in image_url please correct me if I am wrong . so that I can open pull request for it soon. https://paste.ubuntu.com/p/wvxkbHQPdS/ |
"--version" the version of the download script, not the version of firmware
available.
I am going to be somewhat unavailable for the next 5 days, I suggest you
submit a pull request sooner and will have a look.
On Mon, Mar 19, 2018, 12:46 PM Nancy-Chauhan ***@***.***> wrote:
@CarlFK <https://github.com/carlfk> sir As I analyse the issue we have to
just add latest version (which is to be downloaded and make change in
parseargs() as I have done in line no. 93 (
https://paste.ubuntu.com/p/wvxkbHQPdS/) and make necessary change in make
corresponding change in image_url please correct me if I am wrong . so that
I can open pull request for it soon.
https://paste.ubuntu.com/p/wvxkbHQPdS/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABauTBTGBzSt9877XeAq4GUPU9KSarOks5tf-75gaJpZM4RlPnv>
.
<blockquote><img src="https://avatars3.githubusercontent.com/u/23225?s=400&v=4" width="48" align="right"><div><img src="https://assets-cdn.github.com/favicon.ico" height="14"> GitHub</div><div><strong><a href="https://github.com/CarlFK">CarlFK (Carl Karsten)</a></strong></div><div>CarlFK has 50 repositories available. Follow their code on GitHub.</div></blockquote>
<blockquote><div><strong><a href="https://paste.ubuntu.com/p/wvxkbHQPdS/">Ubuntu Pastebin</a></strong></div></blockquote>
<blockquote><div><strong><a href="https://paste.ubuntu.com/p/wvxkbHQPdS/">Ubuntu Pastebin</a></strong></div></blockquote>
<blockquote><img src="https://assets-cdn.github.com/images/modules/open_graph/github-logo.png" width="48" align="right"><div><img src="https://assets-cdn.github.com/favicon.ico" height="14"> GitHub</div><div><strong><a href="https://github.com">Build software better, together</a></strong></div><div>GitHub is where people build software. More than 27 million people use GitHub to discover, fork, and contribute to over 80 million projects.</div></blockquote>
|
No description provided.
The text was updated successfully, but these errors were encountered: