Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely low contrast in diff viewer for comment changes. #23

Open
jyboudreau opened this issue Jul 18, 2018 · 7 comments
Open

Extremely low contrast in diff viewer for comment changes. #23

jyboudreau opened this issue Jul 18, 2018 · 7 comments

Comments

@jyboudreau
Copy link

Summary

Looking at diffs using the VSCode diff editor shows really low contrast text to background especially with backgrounds.

Language: JavaScript (Possibly other languages that have comments syntax highlighting)

Just diff any two files with changes in comments and you can see the problem. Here is a screenshot.

test_diff_contrast

I love Panda syntax, this is the only thing that is really annoying.

@piedrahitapablo
Copy link

I also love Panda syntax, but this issue is even worst when seeing code changes:

image

@Nikodermus
Copy link

+1

1 similar comment
@lukefan6
Copy link

lukefan6 commented Sep 3, 2021

+1

@kashishkhullar
Copy link

As of 2021 I am still facing this issue.
Pandas is amazing, but this single issue is making me switch to a different theme.
😢

@kashishkhullar
Copy link

Found a solution for it.
Customize the color theme is the user settings.

    "workbench.colorCustomizations": {
        "[Panda Syntax]": {
            "diffEditor.insertedTextBackground": "#ff0000" // add some shade of green here
            "diffEditor.removedTextBackground": "#ff0000" // add some shade of red here
        }
    },

@ChrisWongCH
Copy link

Found you will need a alpha value in the colour code so you can still see the letters diff
eg
"diffEditor.removedTextBackground": "#e9464655",
"diffEditor.insertedTextBackground": "#31dc3155"

@dharmjit
Copy link

dharmjit commented Oct 1, 2021

Really liked the theme, but the color for diff viewer is not very eye-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants