Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying a REVIEWED🟢 translation should **automatically** update its state back to TRANSLATED🟡 #2408

Open
calfzhou opened this issue Jul 9, 2024 · 6 comments · May be fixed by #2807
Assignees
Labels
hot We want to do this right now!

Comments

@calfzhou
Copy link

calfzhou commented Jul 9, 2024

Describe the bug

As mentioned in #1147, modifying a base translation will change other language strings' states back to TRANSLATED, and also set a OUTDATED indicator. Which is a great feature.

But I find that, when modifying a REVIEWED🟢 translation (not the base string), its state will not be changed back to TRANSLATED🟡.

To Reproduce

Steps to reproduce the behavior:

Assume that the base language is English, and the second language is German.

  1. Creates a key hello_world, set English string to "Hello World!", and German string to "Hallo Welt!".
  2. Marks the two strings as REVIEWED🟢.
image
  1. Changes the German string to "Hallo Universum!".
image image
  1. The modified German string is still in REVIEWED🟢 state.

Expected behavior

In the 4th step, after saving the new translation text in German string, its state should be automatically changed to TRANSLATED🟡. Then any reviewer could acknowledge the modification, and then review the modified string.

image

Screenshots

Attached in reproduce steps.

Versions and environment

  • Tolgee Platform version: 3.68.2
  • Environment: podman version 5.1.1
  • Browser: Chrome on macOS

Additional context

N/A

@JanCizmar
Copy link
Contributor

Hey! Thanks for reporting. We need to check if this is the standard behaviour in other platforms. We never acutally plan it to work this way, but it makes sense, indeed. 🤔

@DiscowZombie
Copy link

Vouch, the review feature is totally useless with the current behavior

@JanCizmar
Copy link
Contributor

@ZuzanaOdstrcilova do we want to change this behaviour or do we want to add configuration option controlling this?

I believe that reviewers, who edit the string might want to keep the state in reviewed state. However if translator modify the string, it makes sense to update the state.

Anyway reviewers can always change back from translated to reviewed, but translators with limited permissions cannot.

So I think we can proceed with this, right?

@JanCizmar JanCizmar added the hot We want to do this right now! label Dec 20, 2024
@Neele-W
Copy link

Neele-W commented Jan 6, 2025

I believe that reviewers, who edit the string might want to keep the state in reviewed state. However if translator modify the string, it makes sense to update the state. -> Absolutely agree on this! I am Product Manager/Lead, I do not do all the translation changes but should always review the last state before it goes live, when my product managers filled them, and currently its not possible for me to do so, except by trying to identify them based on if they have outdated other translations and then checking the base translation again

@JanCizmar
Copy link
Contributor

@Neele-W

I am sorry but I don't think I understand you comment.

"and currently its not possible for me to do so"

What exactly is not possible?

@Neele-W
Copy link

Neele-W commented Jan 6, 2025

@JanCizmar "l aways review the last state before it goes live" -> I can not identify the last state of a base translation to make sure it is reviewed, when it was reviewed and then changed again by someone.

I have a team of 5 people, in which 2 should be allowed to edit base translations and 3 only for translation of specific language. I am the final base translation reviewer for translation changes and new translations. While for new translations it is easy, for changed translations I could only try to identify these by checking the translations which have another language with a flag on outdated and/or in review state, but in second case, I can never be 100% sure are they like that because someone edited the translation or also edited the base translation AND the other translations. Since other people are in charge for updating outdated translations, I would mostly only encounter second case.

I am not technical enough yet to understand how the deployment plays together with the state of the translations (which would be another topic, in case there is direct one to prod - we chose file for prod for now), which might be another topic on its own.

hope that helps to understand my position?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot We want to do this right now!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants