Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Flash seek length #1028

Open
SandWoodJones opened this issue Dec 5, 2024 · 3 comments
Open

[Feature Request] Flash seek length #1028

SandWoodJones opened this issue Dec 5, 2024 · 3 comments

Comments

@SandWoodJones
Copy link

Is it possible to implement flashing of how many seconds were skipped or rewound? For example, this is how youtube tackles this:
image

@tomasklaen
Copy link
Owner

I wouldn't be against this, but the seek event mpv sends doesn't have any data attached to it that would tell us the length and direction of the seek. We'd have to determine that through some hacks, which I don't like.

Also, it might be noisy, since according to docs, seek event is also fired when mpv itself causes a seek internally, for example when watching ordered matroska chapters, and potentially other reasons. You don't want this to pop up in these situations, and there's no way to differentiate.

So, it's not practical to implement at this moment.

@Solarunit
Copy link

I use native mpv seek osd at the top-left corner, it's less intrusive. Any popup in the center (not on top or bottom) of the video would annoy me.

@SandWoodJones
Copy link
Author

What if it was just a script binding? Since seek doesn't have data attached you'd have to pass the length as a parameter. Would this then be possible?

left seek  -5; script-binding uosc/flash-seek-indicator -5
right seek   5; script-binding uosc/flash-seek-indicator 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants