Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chord.detect does not recognize 7th chords without 3rds #448

Open
biowaffeln opened this issue Nov 3, 2024 · 0 comments
Open

Chord.detect does not recognize 7th chords without 3rds #448

biowaffeln opened this issue Nov 3, 2024 · 0 comments

Comments

@biowaffeln
Copy link

For example, given a chord of ['C3', 'G3', 'B3'], I would expect Chord.detect to produce ['C5maj7'] as an output, however it gives me an empty array:

import { Chord } from 'tonal'

Chord.detect(['C3', 'G3']) // ['C5']
Chord.detect(['C3', 'E3', 'G3', 'B3']) // ['Cmaj7']
Chord.detect(['C3', 'G3', 'B3']) // [], but should be ['C5maj7']
Chord.detect(['C3', 'G3', 'Bb3']) // [], but should be ['C5add7'], or possibly ['C5/7']

For the Chord.detect(['C3', 'G3', 'Bb3']) case you'd have to decide on some sort of notation to keep the numbers separate. I think either C5/7 or C5add7 would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant